-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/new chips #267
Feature/new chips #267
Conversation
ok so @miguelcobain there are a lot of things going on with this PR. I think the best thing for us to do to progress is for us to identify what is wrong with the When I run the demo app it looks like this: https://cloudup.com/cLDVNXnFTfY I thought it looks like the backdrop might be active but I'm not too sure. I checked it just on the I've also created this: #268 because the current JQuery is breaking on that branch. |
Yes. Something is wrong on the wip branch. It happened when we automatically pulled in angular material sass styles. |
Yea, so essentially the main blocker for me on this is that everything seems to be working, but the "delete chip" crosses aren't showing. I think it's best that we solve the general issues before I go into the specifics of why the crosses are missing. Do you think that is a good general strategy? |
Agreed, @mansona. |
820265c
to
8cebf3d
Compare
@miguelcobain yep, looing a lot better now 👍 My next issue is that the autocomplete component is pretty messed up at the moment: https://cloudup.com/cvbltmcbK3d that would be the next one of the "general issues" to deal with I think |
@miguelcobain also do any of the paper-icons work for you? https://cloudup.com/ccE8tyTAra9 |
We aren't including any of the stylesheets for the icons, so none of them are working. Should we link to the material icon font stylesheet directly? |
icons should be working now. |
From research I have seen that autocomplete is changed, and now looks pretty messed up because of contents of the autocomplete is now placed within a new component named |
Unfortunately GitHub doesn't seem to allow you to change the base branch you are PRing against and automatically closes any PRs when the base branch is deleted. Moving forward we are using the |
@SaladFork can you re-open this please? I have rebased and pushed an update |
@mansona - Unfortunately you need to open another PR. In the "great merge", the wip/v1.0.0 branch was merged and deleted. This had the unfortunate side effect of closing all the PR's agains wip/v1.0.0 and there github doesn't seem to have a way to change the target branch. When you do, please reference this PR so we have history. It's a pain, I know. Thanks. |
WIP to update the chips implementation