Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new chips #267

Closed

Conversation

mansona
Copy link
Collaborator

@mansona mansona commented Jan 25, 2016

WIP to update the chips implementation

@mansona
Copy link
Collaborator Author

mansona commented Jan 25, 2016

ok so @miguelcobain there are a lot of things going on with this PR. I think the best thing for us to do to progress is for us to identify what is wrong with the wip/1.0 branch vs what is wrong with whatever I'm doing.

When I run the demo app it looks like this: https://cloudup.com/cLDVNXnFTfY I thought it looks like the backdrop might be active but I'm not too sure. I checked it just on the wip/1.0 branch and it is the same so I don't think it's something that I'm doing locally.

I've also created this: #268 because the current JQuery is breaking on that branch.

@miguelcobain
Copy link
Collaborator

Yes. Something is wrong on the wip branch. It happened when we automatically pulled in angular material sass styles.
Maybe we're not handling hue's, shadows, etc, correctly, @mike1o1 ?

@mansona
Copy link
Collaborator Author

mansona commented Jan 25, 2016

Yea, so essentially the main blocker for me on this is that everything seems to be working, but the "delete chip" crosses aren't showing. I think it's best that we solve the general issues before I go into the specifics of why the crosses are missing. Do you think that is a good general strategy?

@miguelcobain
Copy link
Collaborator

I think it's best that we solve the general issues before I go into the specifics

Agreed, @mansona.

@miguelcobain
Copy link
Collaborator

@mansona, it looks like @mike1o1 has solved the color problems on the wip/1.0 branch.

@mansona
Copy link
Collaborator Author

mansona commented Feb 2, 2016

@miguelcobain yep, looing a lot better now 👍

My next issue is that the autocomplete component is pretty messed up at the moment: https://cloudup.com/cvbltmcbK3d that would be the next one of the "general issues" to deal with I think

@mansona
Copy link
Collaborator Author

mansona commented Feb 2, 2016

@miguelcobain also do any of the paper-icons work for you? https://cloudup.com/ccE8tyTAra9

@mike1o1
Copy link
Contributor

mike1o1 commented Feb 2, 2016

We aren't including any of the stylesheets for the icons, so none of them are working. Should we link to the material icon font stylesheet directly?

@miguelcobain miguelcobain added this to the 1.0 milestone Feb 3, 2016
@miguelcobain
Copy link
Collaborator

icons should be working now.

@peec
Copy link
Contributor

peec commented Feb 5, 2016

From research I have seen that autocomplete is changed, and now looks pretty messed up because of contents of the autocomplete is now placed within a new component named md-virtual-repeat-container. So we basically need to implement the md-virtual-repeat component and then fix autocomplete

@SaladFork SaladFork closed this Apr 19, 2016
@SaladFork
Copy link
Contributor

Unfortunately GitHub doesn't seem to allow you to change the base branch you are PRing against and automatically closes any PRs when the base branch is deleted.

Moving forward we are using the master branch for 1.0.0 work so please feel free to open a new PR against master :)

@mansona
Copy link
Collaborator Author

mansona commented Apr 22, 2016

@SaladFork can you re-open this please? I have rebased and pushed an update

@DanChadwick
Copy link
Contributor

@mansona - Unfortunately you need to open another PR. In the "great merge", the wip/v1.0.0 branch was merged and deleted. This had the unfortunate side effect of closing all the PR's agains wip/v1.0.0 and there github doesn't seem to have a way to change the target branch. When you do, please reference this PR so we have history. It's a pain, I know. Thanks.

@mansona mansona mentioned this pull request Apr 22, 2016
@mansona
Copy link
Collaborator Author

mansona commented Apr 22, 2016

@DanChadwick #344 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants